Bug 25083 - Chromium Linux: use fLeading rather than fHeight
Summary: Chromium Linux: use fLeading rather than fHeight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-07 15:08 PDT by Adam Langley
Modified: 2009-04-07 15:31 PDT (History)
0 users

See Also:


Attachments
patch (1.52 KB, patch)
2009-04-07 15:09 PDT, Adam Langley
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-04-07 15:08:58 PDT
Skia was previously calculating the leading value incorrectly, leading us to add fHeight to get the height of a line of text. Now that Skia is calculating fLeading correctly, we can remove fHeight.

(should be the last one)
Comment 1 Adam Langley 2009-04-07 15:09:51 PDT
Created attachment 29318 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2009-04-07 15:31:14 PDT
Landed as:  http://trac.webkit.org/changeset/42294