Bug 25082 - Clean up repaint logic when composited layers come and go
: Clean up repaint logic when composited layers come and go
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Simon Fraser (smfr)
Depends on:
  Show dependency treegraph
Reported: 2009-04-07 14:26 PDT by Simon Fraser (smfr)
Modified: 2009-04-07 15:41 PDT (History)
0 users

See Also:

Patch, changelog (11.31 KB, patch)
2009-04-07 14:32 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-04-07 14:26:10 PDT
The current code that tries to repaint when RenderLayers become, and stop being compositing does not get it right. This needs cleaning up.
Comment 1 Simon Fraser (smfr) 2009-04-07 14:32:55 PDT
Created attachment 29317 [details]
Patch, changelog
Comment 2 mitz@webkit.org 2009-04-07 14:41:34 PDT
Comment on attachment 29317 [details]
Patch, changelog

> +    if (!repaintContainer)
> +        repaintContainer= m_renderView;

Missing space before the =.

> +    // Update the compositing state of the given layer. Returns true if that state changed.
> +    bool updateLayerCompositingState(RenderLayer*, bool mustRepaint = true);

I would like to channel Darin Adler and suggest that you use an enum instead of a bool.

Comment 3 Simon Fraser (smfr) 2009-04-07 15:41:20 PDT
I did the enum.