Bug 25082 - Clean up repaint logic when composited layers come and go
: Clean up repaint logic when composited layers come and go
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-04-07 14:26 PST by
Modified: 2009-04-07 15:41 PST (History)


Attachments
Patch, changelog (11.31 KB, patch)
2009-04-07 14:32 PST, Simon Fraser (smfr)
mitz: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-04-07 14:26:10 PST
The current code that tries to repaint when RenderLayers become, and stop being compositing does not get it right. This needs cleaning up.
------- Comment #1 From 2009-04-07 14:32:55 PST -------
Created an attachment (id=29317) [details]
Patch, changelog
------- Comment #2 From 2009-04-07 14:41:34 PST -------
(From update of attachment 29317 [details])
> +    if (!repaintContainer)
> +        repaintContainer= m_renderView;

Missing space before the =.

> +    // Update the compositing state of the given layer. Returns true if that state changed.
> +    bool updateLayerCompositingState(RenderLayer*, bool mustRepaint = true);

I would like to channel Darin Adler and suggest that you use an enum instead of a bool.

r=me
------- Comment #3 From 2009-04-07 15:41:20 PST -------
I did the enum.
http://trac.webkit.org/changeset/42291