WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250806
Require Int32 when constant-folding ParseInt in DFG
https://bugs.webkit.org/show_bug.cgi?id=250806
Summary
Require Int32 when constant-folding ParseInt in DFG
David Degazio
Reported
2023-01-18 16:25:43 PST
rdar://104071090
In DFG's constant folding phase, we fold ParseInt nodes when the radix is a Number equal to zero. In the DFG fixup phase, however, we more optimistically assume the radix is an Int32 and add a speculation check. We should make sure that the constant folding phase's behavior reflects the type constraints we introduce in the fixup phase.
Attachments
Add attachment
proposed patch, testcase, etc.
David Degazio
Comment 1
2023-01-18 16:31:21 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8804
EWS
Comment 2
2023-01-19 11:47:54 PST
Committed
259102@main
(47b456d4d7f3): <
https://commits.webkit.org/259102@main
> Reviewed commits have been landed. Closing PR #8804 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug