RESOLVED FIXED 250751
Replace uses of CallFrame::iterate() with StackVisitor::visit(). 
https://bugs.webkit.org/show_bug.cgi?id=250751
Summary Replace uses of CallFrame::iterate() with StackVisitor::visit().
Mark Lam
Reported 2023-01-17 20:18:24 PST
This is blocking the StackVisitor from dumping the JS stack when we encounter Wasm frames. The assertion was from back when Wasm frames didn't exist.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-01-17 20:18:50 PST
<rdar://problem/104363671>
Mark Lam
Comment 2 2023-01-17 21:37:27 PST
(In reply to Mark Lam from comment #0) > This is blocking the StackVisitor from dumping the JS stack when we > encounter Wasm frames. The assertion was from back when Wasm frames didn't > exist. To clarify, I changed the title to reflect the change I'm actually going to make. The assertion in the above comment was from inside CallFrame::iterate(). I ended up doing away with this assertion by removing CallFrame::iterate() altogether.
Mark Lam
Comment 3 2023-01-17 21:43:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/8755
EWS
Comment 4 2023-01-18 08:06:21 PST
Committed 259027@main (59c35e231667): <https://commits.webkit.org/259027@main> Reviewed commits have been landed. Closing PR #8755 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.