Bug 250724 – REGRESSION(258800@main) WinCairo tester buildbot is failing to run API tests due to "builtins.TypeError: 'NoneType' object is not iterable"

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

REGRESSION(258800@main) WinCairo tester buildbot is failing to run API tests due to "builtins.TypeError: 'NoneType' object is not iterable"

Buildbot: builder WinCairo-64-bit-WKL-Release-Tests build 9427
https://build.webkit.org/#/builders/60/builds/9427

> Traceback (most recent call last):
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 47, in run
>     return f(*args, **kwargs)
>   File "/usr/local/lib/python3.6/site-packages/buildbot/process/buildstep.py", line 628, in startStep
>     self.results = yield self.run()
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 1656, in unwindGenerator
>     return _cancellableInlineCallbacks(gen)
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 1571, in _cancellableInlineCallbacks
>     _inlineCallbacks(None, g, status)
> --- <exception caught here> ---
>   File "/usr/local/lib/python3.6/site-packages/buildbot/process/buildstep.py", line 628, in startStep
>     self.results = yield self.run()
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 1445, in _inlineCallbacks
>     result = current_context.run(g.send, result)
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 47, in run
>     return f(*args, **kwargs)
>   File "/usr/local/lib/python3.6/site-packages/buildbot/process/buildstep.py", line 785, in run
>     results = yield self.start()
>   File "/var/buildbot/OpenSource/Tools/CISupport/build-webkit-org/steps.py", line 764, in start
>     for additionalArgument in additionalArguments:
> builtins.TypeError: 'NoneType' object is not iterable

The line was added by 258800@main (bug#250357).

[Fujii Hironori]

Created attachment 464528 [details]
Patch

[Fujii Hironori]

Comment on attachment 464528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464528&action=review

> Tools/CISupport/build-webkit-org/steps.py:764
> +        for additionalArgument in additionalArguments if additionalArguments else []:

This can be simplified as 'additionalArguments or []'.

[Fujii Hironori]

Created attachment 464529 [details]
Patch

[EWS]

Committed 259030@main (6116f9e9eb43): <https://commits.webkit.org/259030@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464529 [details].

[Radar WebKit Bug Importer]

<rdar://problem/104380516>