Bug 250724 - REGRESSION(258800@main) WinCairo tester buildbot is failing to run API tests due to "builtins.TypeError: 'NoneType' object is not iterable"
Summary: REGRESSION(258800@main) WinCairo tester buildbot is failing to run API tests ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-17 12:58 PST by Fujii Hironori
Modified: 2023-01-18 08:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2023-01-17 13:19 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (1.53 KB, patch)
2023-01-17 16:17 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-01-17 12:58:15 PST 
REGRESSION(258800@main) WinCairo tester buildbot is failing to run API tests due to "builtins.TypeError: 'NoneType' object is not iterable"

Buildbot: builder WinCairo-64-bit-WKL-Release-Tests build 9427
https://build.webkit.org/#/builders/60/builds/9427

> Traceback (most recent call last):
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 47, in run
>     return f(*args, **kwargs)
>   File "/usr/local/lib/python3.6/site-packages/buildbot/process/buildstep.py", line 628, in startStep
>     self.results = yield self.run()
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 1656, in unwindGenerator
>     return _cancellableInlineCallbacks(gen)
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 1571, in _cancellableInlineCallbacks
>     _inlineCallbacks(None, g, status)
> --- <exception caught here> ---
>   File "/usr/local/lib/python3.6/site-packages/buildbot/process/buildstep.py", line 628, in startStep
>     self.results = yield self.run()
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 1445, in _inlineCallbacks
>     result = current_context.run(g.send, result)
>   File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 47, in run
>     return f(*args, **kwargs)
>   File "/usr/local/lib/python3.6/site-packages/buildbot/process/buildstep.py", line 785, in run
>     results = yield self.start()
>   File "/var/buildbot/OpenSource/Tools/CISupport/build-webkit-org/steps.py", line 764, in start
>     for additionalArgument in additionalArguments:
> builtins.TypeError: 'NoneType' object is not iterable

The line was added by 258800@main (bug#250357).
Comment 1 Fujii Hironori 2023-01-17 13:19:52 PST 
Created attachment 464528 [details]
Patch
Comment 2 Fujii Hironori 2023-01-17 16:12:02 PST 
Comment on attachment 464528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464528&action=review

> Tools/CISupport/build-webkit-org/steps.py:764
> +        for additionalArgument in additionalArguments if additionalArguments else []:

This can be simplified as 'additionalArguments or []'.
Comment 3 Fujii Hironori 2023-01-17 16:17:44 PST 
Created attachment 464529 [details]
Patch
Comment 4 EWS 2023-01-18 08:19:19 PST 
Committed 259030@main (6116f9e9eb43): <https://commits.webkit.org/259030@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464529 [details].
Comment 5 Radar WebKit Bug Importer 2023-01-18 08:20:17 PST 
<rdar://problem/104380516>