Bug 250708 - REGRESSION(257730@main): [GTK] WebGL 2 not available
Summary: REGRESSION(257730@main): [GTK] WebGL 2 not available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 250783
  Show dependency tree / graph
 
Reported: 2023-01-17 06:05 PST by Kdwk
Modified: 2023-01-18 16:18 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kdwk 2023-01-17 06:05:15 PST 
I have built org.gnome.Platform//master with WebKitGTK 2.39.4, and launched MiniBrowser with this runtime. However, https://get.webgl.org/webgl2/ reports that WebGL 2 is not supported (https://get.webgl.org/webgl/ reports that WebGL is supported). There are no errors or messages in the terminal.
Comment 1 Michael Catanzaro 2023-01-17 08:41:57 PST 
Lovely :S
Comment 2 Michael Catanzaro 2023-01-18 11:01:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8779
Comment 3 Alejandro G. Castro 2023-01-18 12:31:06 PST 
This is a regression of this patch:

 https://github.com/WebKit/WebKit/commit/019d6d9469f55872c49696691e61fdc24f0e5be2 

We need to add a dependency with ENABLE_WEBGL but I don't think that is the right way to do it.
Comment 4 Alejandro G. Castro 2023-01-18 12:31:56 PST 
Michael beat me to upload the patch :-), I tested it and I have another one with fixes of the compilation without WEBGL.
Comment 5 EWS 2023-01-18 16:18:29 PST 
Committed 259059@main (65c06fc0f308): <https://commits.webkit.org/259059@main>

Reviewed commits have been landed. Closing PR #8779 and removing active labels.