Bug 250689 - WebKitGTK 2.39.4 does not build with GCC 13 due to missing #include in ANGLE
Summary: WebKitGTK 2.39.4 does not build with GCC 13 due to missing #include in ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-16 14:19 PST by Michael Catanzaro
Modified: 2023-01-17 07:19 PST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-01-16 14:19:26 PST
In file included from /builddir/build/BUILD/webkitgtk-2.39.4/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.h:17,
                 from /builddir/build/BUILD/webkitgtk-2.39.4/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorESSL.h:10,
                 from /builddir/build/BUILD/webkitgtk-2.39.4/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorESSL.cpp:7:
/builddir/build/BUILD/webkitgtk-2.39.4/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h:127:70: error: 'uint32_t' has not been declared
  127 |     const sh::ShaderVariable *findField(const std::string &fullName, uint32_t *fieldIndexOut) const;
      |                                                                      ^~~~~~~~

Just need to #include cstdint here. Help welcome with upstreaming the change.
Comment 1 Michael Catanzaro 2023-01-16 15:03:44 PST
Pull request: https://github.com/WebKit/WebKit/pull/8705
Comment 2 Michael Catanzaro 2023-01-16 15:07:18 PST
Upstream issue report: https://bugs.chromium.org/p/angleproject/issues/detail?id=7963
Comment 3 EWS 2023-01-16 16:56:49 PST
Committed 258968@main (d318bb461f04): <https://commits.webkit.org/258968@main>

Reviewed commits have been landed. Closing PR #8705 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-01-16 16:57:16 PST
<rdar://problem/104311773>