Bug 250680 - [WGSL] Use String instead of StringView for Identifiers
Summary: [WGSL] Use String instead of StringView for Identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-16 07:55 PST by Tadeu Zagallo
Modified: 2023-01-18 12:17 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2023-01-16 07:55:54 PST 
There should be no extra cost if create the string without copying and it allows us to use runtime-generated strings which will be necessary soon
Comment 1 Radar WebKit Bug Importer 2023-01-16 07:56:10 PST 
<rdar://problem/104299588>
Comment 2 Tadeu Zagallo 2023-01-16 08:09:04 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8697
Comment 3 EWS 2023-01-18 12:17:33 PST 
Committed 259044@main (b965bbcd7618): <https://commits.webkit.org/259044@main>

Reviewed commits have been landed. Closing PR #8697 and removing active labels.