Bug 250639 - Fix handling of bidirectional override
Summary: Fix handling of bidirectional override
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-15 03:56 PST by Ahmad Saleem
Modified: 2023-01-21 12:50 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.19 KB, patch)
2023-01-20 20:07 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (52.62 KB, patch)
2023-01-21 06:39 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-15 03:56:35 PST
Hi Team,

While going through Blink's commit, I came across another failing test in Safari 16.2 and Safari Technology Preview 161:

Test Case - https://jsfiddle.net/yajew02c/show

^ The text is not contained within bounds of white box, 'daal' (in roman Arabic or Urdu) is in grey region.

Chrome Canary 111 and Firefox Nightly 110 works fine in above:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/fe79ee4457111490064d8bf9b6c5dce97f26b5d4

Don't know whether 1-1 merge is possible or not but just wanted to raise so we can track it.

Thanks!
Comment 1 zalan 2023-01-20 20:07:34 PST
Created attachment 464585 [details]
Patch
Comment 2 zalan 2023-01-20 20:09:05 PST
we don't use BidiResolver in IFC anymore, so fixing it in WebKit requires a very different approach (see patch).
Comment 3 zalan 2023-01-21 06:39:23 PST
Created attachment 464586 [details]
Patch
Comment 4 EWS 2023-01-21 12:49:58 PST
Committed 259172@main (ac34f5d6508f): <https://commits.webkit.org/259172@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464586 [details].
Comment 5 Radar WebKit Bug Importer 2023-01-21 12:50:17 PST
<rdar://problem/104514372>