WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250628
[GStreamer] Implement Speech Synthesis with Flite
https://bugs.webkit.org/show_bug.cgi?id=250628
Summary
[GStreamer] Implement Speech Synthesis with Flite
ChangSeok Oh
Reported
2023-01-14 16:24:46 PST
Let's discuss the web speech synthesis for ports using gstreamer here. We have a working branch:
https://github.com/shivamidow/WebKit/tree/eng/speech-synthesis-with-gst-flite
This patch passed 22 / 26 webkit tests in fast/speechsynthesis. 4 test failed due to crash and unknown reasons. We need to investigate it more.
Attachments
Add attachment
proposed patch, testcase, etc.
ChangSeok Oh
Comment 1
2023-01-15 12:03:28 PST
I don't want to delay this patch for further bug fixes. It is itself a huge chunk so I suggest splitting the web speech synthesis support into some phases. Phase 1. Support build and basic functionalities (e.g., play, stop, pause, cancel) -> the current patch Phase 2. Fix bugs on layout tests (fast/speechsynthesis) and enable the tests Phase 3. Further bug fixes as we find new ones. @philn, thought?
ChangSeok Oh
Comment 2
2023-01-15 12:23:29 PST
Or we can enable fast/speechsynthesis in phase 1 but add failed 4 tests as exceptions to fix later.
Philippe Normand
Comment 3
2023-01-15 14:21:22 PST
> Phase 1. Support build and basic functionalities (e.g., play, stop, pause, cancel) -> the current patch
Without GStreamer usage from UIProcess?
ChangSeok Oh
Comment 4
2023-01-15 15:50:29 PST
(In reply to Philippe Normand from
comment #3
)
> > Phase 1. Support build and basic functionalities (e.g., play, stop, pause, cancel) -> the current patch > > Without GStreamer usage from UIProcess?
Yes. That was fixed already. =)
ChangSeok Oh
Comment 5
2023-01-15 20:52:05 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8677
EWS
Comment 6
2023-01-22 14:47:55 PST
Committed
259197@main
(f99efce2948a): <
https://commits.webkit.org/259197@main
> Reviewed commits have been landed. Closing PR #8677 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug