Bug 25058 - Fix chromium build bustage caused by r42216
Summary: Fix chromium build bustage caused by r42216
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-06 10:55 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-04-06 13:49 PDT (History)
2 users (show)

See Also:

Attachments
v1 patch (1.52 KB, patch)
2009-04-06 11:10 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
Details | Formatted Diff | Diff
v2 patch (5.55 KB, patch)
2009-04-06 13:36 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-04-06 10:55:35 PDT 
Fix chromium build bustage caused by r42216

That change included the following patch to DOMWindow.idl:http://trac.webkit.org/changeset/42216/trunk/WebCore/page/DOMWindow.idl

Those changes should have used the JSC prefix for Custom attributes.  Patch coming up...
Comment 1 Darin Fisher (:fishd, Google) 2009-04-06 11:10:20 PDT 
Created attachment 29280 [details]
v1 patch
Comment 2 Dimitri Glazkov (Google) 2009-04-06 11:16:55 PDT 
Comment on attachment 29280 [details]
v1 patch

Ok.
Comment 3 Darin Fisher (:fishd, Google) 2009-04-06 11:24:02 PDT 
Landed as:  http://trac.webkit.org/changeset/42249
Comment 4 Darin Fisher (:fishd, Google) 2009-04-06 11:42:10 PDT 
Whoops, that was not quite right.  I revert this in r42250.
Comment 5 Darin Fisher (:fishd, Google) 2009-04-06 13:36:55 PDT 
Created attachment 29287 [details]
v2 patch

Version 2, which actually works.  It turns out that you cannot combine CustomGetter and CustomSetter.  So, now I am using JSCCustom and V8CustomSetter.
Comment 6 Dimitri Glazkov (Google) 2009-04-06 13:47:21 PDT 
Comment on attachment 29287 [details]
v2 patch

This one better work.
Comment 7 Darin Fisher (:fishd, Google) 2009-04-06 13:49:31 PDT 
http://trac.webkit.org/changeset/42254