RESOLVED FIXED 25058
Fix chromium build bustage caused by r42216 
https://bugs.webkit.org/show_bug.cgi?id=25058
Summary Fix chromium build bustage caused by r42216
Darin Fisher (:fishd, Google)
Reported 2009-04-06 10:55:35 PDT
Fix chromium build bustage caused by r42216 That change included the following patch to DOMWindow.idl:http://trac.webkit.org/changeset/42216/trunk/WebCore/page/DOMWindow.idl Those changes should have used the JSC prefix for Custom attributes. Patch coming up...
Attachments
v1 patch (1.52 KB, patch)
2009-04-06 11:10 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
DetailsFormatted DiffDiff
v2 patch (5.55 KB, patch)
2009-04-06 13:36 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-04-06 11:10:20 PDT
Created attachment 29280 [details] v1 patch
Dimitri Glazkov (Google)
Comment 2 2009-04-06 11:16:55 PDT
Comment on attachment 29280 [details] v1 patch Ok.
Darin Fisher (:fishd, Google)
Comment 3 2009-04-06 11:24:02 PDT
Landed as: http://trac.webkit.org/changeset/42249
Darin Fisher (:fishd, Google)
Comment 4 2009-04-06 11:42:10 PDT
Whoops, that was not quite right. I revert this in r42250.
Darin Fisher (:fishd, Google)
Comment 5 2009-04-06 13:36:55 PDT
Created attachment 29287 [details] v2 patch Version 2, which actually works. It turns out that you cannot combine CustomGetter and CustomSetter. So, now I am using JSCCustom and V8CustomSetter.
Dimitri Glazkov (Google)
Comment 6 2009-04-06 13:47:21 PDT
Comment on attachment 29287 [details] v2 patch This one better work.
Darin Fisher (:fishd, Google)
Comment 7 2009-04-06 13:49:31 PDT
http://trac.webkit.org/changeset/42254
Note You need to log in before you can comment on or make changes to this bug.