RESOLVED FIXED 250510
Validate animation key paths sent over IPC 
https://bugs.webkit.org/show_bug.cgi?id=250510
Summary Validate animation key paths sent over IPC
Antoine Quint
Reported 2023-01-12 04:16:40 PST
We currently send a CAAnimation's keyPath over IPC as a String. We should send this as a struct for the string to be generated in the UI Process for added security.
Attachments
Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2023-01-12 04:16:54 PST
rdar://102433824
Antoine Quint
Comment 2 2023-01-12 12:14:17 PST
Pull request: https://github.com/WebKit/WebKit/pull/8587
Antoine Quint
Comment 3 2023-01-16 01:16:13 PST
Simon suggested that we keep using strings to represent animation key paths but instead validate the string in the UIProcess once received before creating the CAAnimation. Renaming bug to track this effort.
Antoine Quint
Comment 4 2023-01-16 01:28:28 PST
Pull request: https://github.com/WebKit/WebKit/pull/8680
EWS
Comment 5 2023-01-17 08:58:18 PST
Committed 258986@main (a4467affde12): <https://commits.webkit.org/258986@main> Reviewed commits have been landed. Closing PR #8680 and removing active labels.
WebKit Commit Bot
Comment 6 2023-01-17 17:43:34 PST
Re-opened since this is blocked by bug 250744
Antoine Quint
Comment 7 2023-01-18 02:03:33 PST
Pull request: https://github.com/WebKit/WebKit/pull/8760
EWS
Comment 8 2023-01-18 22:44:37 PST
Committed 259066@main (f554fc01c126): <https://commits.webkit.org/259066@main> Reviewed commits have been landed. Closing PR #8760 and removing active labels.
Antoine Quint
Comment 9 2023-02-01 11:30:40 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9466
Antoine Quint
Comment 10 2023-02-01 11:33:51 PST
Mistakenly re-opened this, closing it again.
Note You need to log in before you can comment on or make changes to this bug.