Bug 250462 - Move transformationForTextBox() call out of the fragment-loop
Summary: Move transformationForTextBox() call out of the fragment-loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-11 09:44 PST by Ahmad Saleem
Modified: 2023-01-13 12:40 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-11 09:44:43 PST 
Hi Team,

While going through Blink's commit, I came across another refactoring:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=177517&view=revision

WebKit Source - https://github.com/WebKit/WebKit/blob/fee955ee6904a3764cbb38e260690dbc4de71338/Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp#L280

It does not have any test case, just wanted to get input whether it is worth doing this refactoring.

Thanks!
Comment 1 EWS 2023-01-13 12:38:30 PST 
Committed 258886@main (e1696eb5587f): <https://commits.webkit.org/258886@main>

Reviewed commits have been landed. Closing PR #8570 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-01-13 12:40:19 PST 
<rdar://problem/104235971>