Bug 250403 – [GPU Process] DrawFocusRing with timeOffset is not recorded for macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Said Abou-Hallawa]

The Recorder::drawFocusRing() versions with timeOffset are not implemented. But after looking at the code, it turned out the timeOffset was never used and we always pass std::numeric_limits<double>::max() to NSInitializeCGFocusRingStyleForTime(). This means the return value of NSInitializeCGFocusRingStyleForTime()() is always false. So we do not need to pass the arguments: timeOffset and needsRepaint to drawFocusRing. Therefore the Mac versions of GraphicsContext::drawFocusRing() are not needed.

So we can have two versions only of GraphicsContext::drawFocusRing():

1. One that takes (const Path&, float outlineWidth, ...). The outlineWidth is used to set the lineWidth on Cairo and to set the blurRadius on Windows.
1. One that takes (const Vector<FloatRect>&, float outlineOffset, float outlineWidth, ...). The outlineOffset is used to shrink the focus ring rectangles. On Cocoa and Windows, this version will convert the rects to a Path and call the previous one.

[Said Abou-Hallawa]

rdar://104039216

[Said Abou-Hallawa]

Pull request: https://github.com/WebKit/WebKit/pull/8481

[EWS]

Committed 258794@main (1100c0ba6eb7): <https://commits.webkit.org/258794@main>

Reviewed commits have been landed. Closing PR #8481 and removing active labels.