Bug 250398 - Unable to reset messages.py unit test results
Summary: Unable to reset messages.py unit test results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 171627
Blocks:
  Show dependency tree / graph
 
Reported: 2023-01-10 11:06 PST by David Kilzer (:ddkilzer)
Modified: 2023-01-10 15:40 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-01-10 11:06:52 PST 
I am currently unable to reset messages.py unit test results.

$ xcrun python3 Source/WebKit/Scripts/webkit/messages_unittest.py -r
Traceback (most recent call last):
  File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 145, in <module>
    add_reset_results_to_unittest_help()
  File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 121, in add_reset_results_to_unittest_help
    lines = unittest.TestProgram.USAGE.splitlines(True)
AttributeError: type object 'TestProgram' has no attribute 'USAGE'
$ 

I'm not sure when this started failing--maybe after the Python3 update?
Comment 1 Radar WebKit Bug Importer 2023-01-10 11:07:10 PST 
<rdar://problem/104085791>
Comment 2 David Kilzer (:ddkilzer) 2023-01-10 11:10:09 PST 
LOL...I have only myself to blame:

    Bug 171627: messages_unittest.py should support a [-r|--reset-results] switch
    <https://bugs.webkit.org/show_bug.cgi?id=171627>
Comment 3 Radar WebKit Bug Importer 2023-01-10 11:10:20 PST 
<rdar://problem/104085961>
Comment 4 David Kilzer (:ddkilzer) 2023-01-10 11:11:14 PST 
<rdar://problem/104085791>
Comment 5 David Kilzer (:ddkilzer) 2023-01-10 12:30:37 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8477
Comment 6 EWS 2023-01-10 15:40:26 PST 
Committed 258748@main (639329ca6b9a): <https://commits.webkit.org/258748@main>

Reviewed commits have been landed. Closing PR #8477 and removing active labels.