Bug 25036 - [GTK] Implement layoutTestController.waitForPolicyDelegate
Summary: [GTK] Implement layoutTestController.waitForPolicyDelegate
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: Gtk, LayoutTestFailure, PlatformOnly
Depends on:
Reported: 2009-04-03 14:12 PDT by Adam Roben (:aroben)
Modified: 2009-05-15 00:57 PDT (History)
1 user (show)

See Also:

implement waitForPolicyDelegate and enable mailto tests (6.39 KB, patch)
2009-05-12 07:26 PDT, Jan Alonzo
no flags Details | Formatted Diff | Diff
updated patch (7.52 KB, patch)
2009-05-12 08:34 PDT, Jan Alonzo
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-04-03 14:12:12 PDT
r42056 added layoutTestController.waitForPolicyDelegate, and r42057 made a number of tests depend on it. This functionality needs to be implemented in the GTK+ port in order to run these tests. I've added these tests to LayoutTests/platform/gtk/Skipped.
Comment 1 Jan Alonzo 2009-05-12 07:26:37 PDT
Created attachment 30227 [details]
implement waitForPolicyDelegate and enable mailto tests
Comment 2 Jan Alonzo 2009-05-12 08:04:06 PDT
Comment on attachment 30227 [details]
implement waitForPolicyDelegate and enable mailto tests

Patch needs more work.. clearing review.
Comment 3 Jan Alonzo 2009-05-12 08:34:36 PDT
Created attachment 30230 [details]
updated patch

Updated the patch to check for waitForPolicy instead of waitToDumpWatchdog. This should also pass the existing enabled tests.
Comment 4 Holger Freyther 2009-05-14 05:31:30 PDT
Comment on attachment 30230 [details]
updated patch

Looks great.
Comment 5 Eric Seidel (no email) 2009-05-15 00:57:23 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/Skipped
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
	M	WebKitTools/DumpRenderTree/gtk/DumpRenderTreeGtk.h
	M	WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
Committed r43760