Bug 250281 – Remove unused attributes from HTMLAttributeNames.in

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ahmad Saleem]

Hi Team,

I am not able to find anything beside this line here and it seems Blink also got rid of it:

Reference: https://github.com/WebKit/WebKit/blob/8b8f0c201eb0d1a96590a17ab6b6908f137707c0/Source/WebCore/html/HTMLAttributeNames.in#L446

Can we also remove this now? If it is not supported in WebKit etc.?

Thanks!

[Tim Nguyen (:ntim)]

There doesn't seem any usages of `webkitgrammarAttr` in the codebase, so seems like unused code to me.

[Tim Nguyen (:ntim)]

x-webkit-imagemenu / x-webkit-speech / x-webkit-airplay seem unused as well. I bet there's more unused ones too. 

You can do a plain text search for the generated indentifiers to check: https://searchfox.org/wubkat/source/__GENERATED__/WebCore/DerivedSources/HTMLNames.cpp#2998

[Ahmad Saleem]

(In reply to Tim Nguyen (:ntim) from comment #2)
> x-webkit-imagemenu / x-webkit-speech / x-webkit-airplay seem unused as well.
> I bet there's more unused ones too. 
> 
> You can do a plain text search for the generated indentifiers to check:
> https://searchfox.org/wubkat/source/__GENERATED__/WebCore/DerivedSources/
> HTMLNames.cpp#2998

Yes, I think I might rename this bug title and try to find all which seems unused and ask for some input. Few days back, I asked on Slack to Ryosuke about similar Blink commit, where they removed a bunch of these. Let me try to find it in morning and compile list here and get input. Can do PR to clean all in one go.

[Ahmad Saleem]

So I

[Ahmad Saleem]

--> x-webkit-speech

https://github.com/WebKit/WebKit/blob/866813ec2e4eb4f8646237cccfe1ad3ad76f46e1/Source/WebCore/html/HTMLAttributeNames.in#L445

--> x-webkit-imagemenu

https://github.com/WebKit/WebKit/blob/866813ec2e4eb4f8646237cccfe1ad3ad76f46e1/Source/WebCore/html/HTMLAttributeNames.in#L446

--> x-webkit-airplay

https://github.com/WebKit/WebKit/blob/866813ec2e4eb4f8646237cccfe1ad3ad76f46e1/Source/WebCore/html/HTMLAttributeNames.in#L444

## Few more:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/674f886367e5835520a68d15bcaf36d4493d5a26

Following:

aria-setsize
aria-posinset
aria-sort
cellborder
disposition
expanded
focused
indeterminate
itemid
itemprop
itemref
itemscope
itemtype
playcount
loopend
loopstart
onwebkitspeechchange
onwebkitkeyadded
onwebkitkeyerror
onwebkitkeymessage
onwebkitneedkey
onwebkitsourceclose
onwebkitsourceended
onwebkitsourceopen
pluginspage
pluginurl
primary
progress
prompt
sortable
sortdirection
tableborder
top

[Tyler Wilcock]

aria-setsize, aria-posinset, and aria-sort are in use.

[Radar WebKit Bug Importer]

<rdar://problem/104267186>

[Anne van Kesteren]

Pull request: https://github.com/WebKit/WebKit/pull/13869

[EWS]

Committed 264069@main (5bca27238be0): <https://commits.webkit.org/264069@main>

Reviewed commits have been landed. Closing PR #13869 and removing active labels.