Bug 250270 - REGRESSION (256989@main): YouTube "read more" links are missing, long comments cut off
Summary: REGRESSION (256989@main): YouTube "read more" links are missing, long comment...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Mac (Apple Silicon) macOS 13
: P1 Critical
Assignee: zalan
URL:
Keywords: InRadar
: 250071 250563 250636 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-01-07 07:29 PST by Aaron Graves
Modified: 2023-01-25 18:42 PST (History)
9 users (show)

See Also:

Attachments
Screenshot from production Safari (153.95 KB, image/png)
2023-01-07 07:29 PST, Aaron Graves 		no flags Details
Screenshot from Safari Tech Preview, showing the missing Read more link (130.81 KB, image/png)
2023-01-07 07:30 PST, Aaron Graves 		no flags Details
Patch (10.71 KB, patch)
2023-01-09 15:47 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.94 KB, patch)
2023-01-09 20:35 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.98 KB, patch)
2023-01-10 08:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Graves 2023-01-07 07:29:38 PST 
Created attachment 464396 [details]
Screenshot from production Safari

Navigate to any video on YouTube where there are long comments (and would normally trigger a read more link). I recommend https://www.youtube.com/watch?v=cUkbdqw9pBk. Note that the read more link is missing, and all you get is the cut off text.
Comment 1 Aaron Graves 2023-01-07 07:30:11 PST 
Created attachment 464397 [details]
Screenshot from Safari Tech Preview, showing the missing Read more link
Comment 2 zalan 2023-01-07 08:08:44 PST 
<rdar://103942782>
Comment 3 zalan 2023-01-09 12:47:50 PST 
This is caused by the lack of scrollable overflow with clamped content (IFC does not compute lines beyond the clamped content).
It starts working fine soon after scrollable overflow is added.
Comment 4 zalan 2023-01-09 15:47:22 PST 
Created attachment 464428 [details]
Patch
Comment 5 zalan 2023-01-09 16:03:00 PST 
*** Bug 250071 has been marked as a duplicate of this bug. ***
Comment 6 zalan 2023-01-09 20:35:37 PST 
Created attachment 464438 [details]
Patch
Comment 7 zalan 2023-01-10 08:17:33 PST 
Created attachment 464442 [details]
Patch
Comment 8 EWS 2023-01-10 09:53:50 PST 
Committed 258730@main (f34b777b4bff): <https://commits.webkit.org/258730@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464442 [details].
Comment 9 Karl Dubost 2023-01-15 18:52:56 PST 
*** Bug 250636 has been marked as a duplicate of this bug. ***
Comment 10 zalan 2023-01-16 15:09:47 PST 
*** Bug 250563 has been marked as a duplicate of this bug. ***
Comment 11 Vladimir Prelovac 2023-01-25 17:22:09 PST 
Any idea when this will be merged/tagged? Latest SafariTP (162) still didn't include it.
Comment 12 zalan 2023-01-25 18:42:56 PST 
(In reply to Vladimir Prelovac from comment #11)
> Any idea when this will be merged/tagged? Latest SafariTP (162) still didn't
> include it.
While I don't know when this is going to be merged,
according to https://webkit.org/blog/13703/release-notes-for-safari-technology-preview-162/, 162 includes WebKit changes between: 258383@main…258608@main. This fix missed the cut off by ~4 days(122 commits), but it also looks to be an awfully short range compared to previous STPs (e.g. 257351@main…258382@main and 256265@main…257350@main).