RESOLVED FIXED250235
Do not automatically enable 'developer' features during tests 
https://bugs.webkit.org/show_bug.cgi?id=250235
Summary Do not automatically enable 'developer' features during tests
Brent Fulgham
Reported 2023-01-06 14:57:08 PST
The generator logic added in Bug 247926 also activated features with 'developer' status while running tests. However, the 'developer' flags with a defaultValue of 'false' are generally not relevant to testing (e.g., enabling security-violating CORS state, enabling features not meant for web use cases, etc. TestWebKitAPI tests that need these special settings already enable the individually, so we should not hard-set them to 'true' at each test iteration, as this can also enables features on platforms or configurations that need these features to be off.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-01-06 14:57:25 PST
<rdar://problem/103969233>
Brent Fulgham
Comment 2 2023-01-06 15:10:16 PST
This issue also applies to 'stable' features, which are already in the correct state for each platform, and should not be arbitrarily toggled on for testing.
Brent Fulgham
Comment 3 2023-01-06 16:01:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/8327
Brent Fulgham
Comment 4 2023-01-09 10:01:16 PST
Note: After noticing issues with GTK/WPE, we decided to continue enable 'stable' feature for now.
EWS
Comment 5 2023-01-09 13:14:12 PST
Committed 258681@main (1a660cb880b4): <https://commits.webkit.org/258681@main> Reviewed commits have been landed. Closing PR #8327 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.