WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250227
Add exclusive "shouldBeGreaterThan" function to js-test.js similar to Chromium
https://bugs.webkit.org/show_bug.cgi?id=250227
Summary
Add exclusive "shouldBeGreaterThan" function to js-test.js similar to Chromium
Ahmad Saleem
Reported
2023-01-06 13:10:04 PST
Hi Team, While trying to do following PR and in the test of it:
https://github.com/WebKit/WebKit/pull/8305/files#diff-c2c39a91b22f93f030d4c452050c08bc0b5d2632af2f40215a5acc58582a0d9bR18
I noted that it has dedicated "shouldBeGreaterThan" test compared to "shouldBeGreaterThanOrEqual", we have. I checked on Chromium source and they have it separate:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/resources/js-test.js;l=601?q=shouldBeGreaterThan
I think it would be fine and good enhancement to add it for even future use cases. Just wanted to get opinion and raise it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-01-07 06:40:48 PST
Committed
258613@main
(24d9e4a1e3d3): <
https://commits.webkit.org/258613@main
> Reviewed commits have been landed. Closing PR #8321 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-01-07 06:41:16 PST
<
rdar://problem/103987760
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug