Bug 250215 - REGRESSION(257981@main): Form control focus ring is clipped when zooming in
Summary: REGRESSION(257981@main): Form control focus ring is clipped when zooming in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-06 09:33 PST by Said Abou-Hallawa
Modified: 2023-01-06 11:37 PST (History)
4 users (show)

See Also:

Attachments
test case (341 bytes, text/html)
2023-01-06 09:33 PST, Said Abou-Hallawa 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-01-06 09:33:17 PST 
Created attachment 464376 [details]
test case

1. Open the attached test case
2. Click inside the search field

Result: The focus ring is clipped.

In 257981@main, ThemeMac::drawCellOrFocusRingWithViewIntoContext() was refactored to ControlMac::drawCell(). In these two functions, the NSCell drawing will be routed to an ImageBuffer if the page is zoomed. After the drawing this ImageBuffer is drawn into the destination context. When the form control is focused, we ask AppKit to draw also a focus ring around the rectangle of form control. AppKit bleeds at maximum three pixels around the drawing rectangle. hemeMac::drawCellOrFocusRingWithViewIntoContext() handles this issue by inflating the ImageBuffer size by three pixels. This size inflation needs to be ported to ControlMac::drawCell().
Comment 1 Radar WebKit Bug Importer 2023-01-06 09:36:36 PST 
<rdar://problem/103958015>
Comment 2 Said Abou-Hallawa 2023-01-06 09:45:23 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8309
Comment 3 EWS 2023-01-06 11:37:03 PST 
Committed 258553@main (2d409b2f1e10): <https://commits.webkit.org/258553@main>

Reviewed commits have been landed. Closing PR #8309 and removing active labels.