Bug 25016 – max-width and max-height are not overriding the width and height properties when 'display' set to 'table'

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[jasneet]

I Steps:
1. Go to attached testcase

II Issue: 
width and height are overriding max-width and max-height (max-width and max-height must override width and height)

III Other Browsers:
FF3: OK
IE7: OK 

IV Nightly tested: 42138

Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=9550

[jasneet]

Created attachment 29213 [details]
testcase

[Daniel Katz]

There is a minor mistake in 'Other browsers' section: IE7 doesn't support 'display:table' at all, so originally I've tested the test case on IE8.

IE8: OK

[Eric Seidel (no email)]

Hyatt?

I have confirmed that our behavior does not match FF3.

[Eric Seidel (no email)]

Hyatt says that tables have had this bug forever.  In general our table support needs improving.  Perhaps a member of the Tokyo team would be up to the task.

[Julius Stroffek]

Any chance that somebody will look into this?
Are there any workarounds?

[Stephen Cantini]

+1 Some time has passed... any news? The only workaround I have found is wrapping the table inside a div with "max-width" set...a css-only solution would be much appreciated.

[Eric Seidel (no email)]

The bug is presumably in RenderBox::computeLogicalHeight:
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBox.cpp#L2025

[Stephen Cantini]

DISCLAIMER: I've never looked at the webkit code before.

Could it be in RenderBox::computeLogicalWidthInRegion() for the ignored "max-width" part? If this is the case, maybe it never reaches this if statement http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBox.cpp#L1765

[Stephen Cantini]

Any news from the tokyo team or anybody else on this issue? Is there anything else I can do to help solve it? Someone to contact directly?

[Tony Chang]

The bug is probably in RenderTable::updateLogicalWidth.  You can see that it checks against min-width, but there's no code for max-width.
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTable.cpp?rev=129929#L258

I'm not sure how table height gets computed, but if you look in RenderBox::computeLogicalHeight, it only calculates margins.  I suspect the height is updated by it's children or something.

[Julien Chaffraix]

> I'm not sure how table height gets computed, but if you look in RenderBox::computeLogicalHeight, it only calculates margins.  I suspect the height is updated by it's children or something.

The logical height computation is in RenderTable::layout(). We need to check for the min / max logical height and update |computedLogicalHeight| accordingly.

Note that the effect of min / max width / height on tables is undefined in CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#propdef-max-width) so we will need to evaluate what other browsers are doing in some corner cases (e.g. should we shrink our content if max-height is defined? (we never shrink our height currently as it would violate CSS 2.1 tables: we could make a cell smaller than the minimum height for its content))

[Julien Chaffraix]

After bug 98455 and bug 98633, this is fixed.