Bug 250150 - [git-webkit] Handle no TTY in credentials sub-command
Summary: [git-webkit] Handle no TTY in credentials sub-command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-05 14:39 PST by Jonathan Bedard
Modified: 2023-01-05 15:18 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-01-05 14:39:58 PST 
git-webkit credentials is often invoked by git to pull a token used for git fetch or push. In the event no token can be found, this will result in an ugly stack-trace about invoking git-webkit outside a TTY. git-webkit credentials should more gracefully handle this relatively common use case.
Comment 1 Radar WebKit Bug Importer 2023-01-05 14:40:12 PST 
<rdar://problem/103928951>
Comment 2 Jonathan Bedard 2023-01-05 14:41:45 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8252
Comment 3 EWS 2023-01-05 15:18:45 PST 
Committed 258512@main (43ff7544e6f6): <https://commits.webkit.org/258512@main>

Reviewed commits have been landed. Closing PR #8252 and removing active labels.