RESOLVED FIXED 250149
Add plumbing for Gamepad.vibrationActuator support 
https://bugs.webkit.org/show_bug.cgi?id=250149
Summary Add plumbing for Gamepad.vibrationActuator support
Chris Dumez
Reported 2023-01-05 14:01:40 PST
Add plumbing for Gamepad.vibrationActuator support: - https://w3c.github.io/gamepad/extensions.html#dom-gamepadhapticactuator
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-01-05 14:17:49 PST
Pull request: https://github.com/WebKit/WebKit/pull/8251
EWS
Comment 2 2023-01-06 13:57:03 PST
Committed 258559@main (7203ee047b6c): <https://commits.webkit.org/258559@main> Reviewed commits have been landed. Closing PR #8251 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-01-06 13:58:16 PST
<rdar://problem/103966957>
Michael Catanzaro
Comment 4 2023-01-06 16:05:05 PST
Looks like this broke the GTK build: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&, WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&, WTF::CompletionHandler<void(bool)>&&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:52:22: error: no match for call to ‘(WTF::CompletionHandler<void(bool)>) (bool)’ 52 | completionHandler(false); | ~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&, WTF::CompletionHandler<void()>&&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:57:22: error: no match for call to ‘(WTF::CompletionHandler<void()>) ()’ 57 | completionHandler(); | ~~~~~~~~~~~~~~~~~^~ The code *looks* correct, though...
Chris Dumez
Comment 5 2023-01-06 16:11:22 PST
(In reply to Michael Catanzaro from comment #4) > Looks like this broke the GTK build: > > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp: In member function ‘virtual void > WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&, > WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&, > WTF::CompletionHandler<void(bool)>&&)’: > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp:52:22: error: no match for call to > ‘(WTF::CompletionHandler<void(bool)>) (bool)’ > 52 | completionHandler(false); > | ~~~~~~~~~~~~~~~~~^~~~~~~ > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp: In member function ‘virtual void > WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&, > WTF::CompletionHandler<void()>&&)’: > /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/ > EmptyGamepadProvider.cpp:57:22: error: no match for call to > ‘(WTF::CompletionHandler<void()>) ()’ > 57 | completionHandler(); > | ~~~~~~~~~~~~~~~~~^~ > > The code *looks* correct, though... Maybe we need to include <wtf/CompletionHandler.h> inside EmptyGamepadProvider.cpp. Would you be able to try?
Michael Catanzaro
Comment 6 2023-01-06 16:16:03 PST
I had the same idea. Pretty sure it worked: my build is nearly done....
Michael Catanzaro
Comment 7 2023-01-06 16:21:47 PST
Yes, that works.
Michael Catanzaro
Comment 8 2023-01-06 16:24:23 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/8331
EWS
Comment 9 2023-01-06 16:27:57 PST
Committed 258578@main (3383a19ab4f9): <https://commits.webkit.org/258578@main> Reviewed commits have been landed. Closing PR #8331 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.