NEW 250106
Remove <!-- webkit-test-runner --> modeline from imported tests 
https://bugs.webkit.org/show_bug.cgi?id=250106
Summary Remove <!-- webkit-test-runner --> modeline from imported tests
Elliott Williams
Reported 2023-01-04 14:38:15 PST
We shouldn't export the <!-- webkit-test-runner --> control statements to WPT. Instead, let's mark features WPT uses as `testable`, or mark the tests as expected to fail. Moreover, I'd argue that we should avoid testing WPT using feature flags that are only turned on by our CI infra, so that our CI's ability to pass tests is reflective of WebKit's public WPT score.
Attachments
Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2023-01-04 15:00:55 PST
I think it's reasonable for us to have 'testable' features that run WPT locally to help us avoid regression bits of a feature that work while trying to complete other work. If we think the feature is usable, we would make it 'preview', and it should show in STP scores for WPT. Once it's on-by-default it would show in stable scores for WPT. I think this is a good idea to avoid artificial differences in WPT results, and to avoid modifying WPT tests as much as possible.
Tim Nguyen (:ntim)
Comment 2 2023-01-04 15:03:26 PST
I think the problem here is that if we don't export those changes, they get overriden next time someone imports.
Brent Fulgham
Comment 3 2023-01-04 15:12:28 PST
Right -- what I'm saying is that we should ditch the special comment, and just mark relevant features as 'testable' (just as Elliott suggested in this bug).
Tim Nguyen (:ntim)
Comment 4 2023-01-09 02:03:54 PST
Yeah that sounds reasonable.
Radar WebKit Bug Importer
Comment 5 2023-01-11 14:39:16 PST
<rdar://problem/104140583>
Note You need to log in before you can comment on or make changes to this bug.