Bug 25010 - Convert all JS function invocations in InspectorController to use ScriptFunctionCall
Summary: Convert all JS function invocations in InspectorController to use ScriptFunct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-02 14:08 PDT by Dimitri Glazkov (Google)
Modified: 2009-04-02 14:49 PDT (History)
1 user (show)

See Also:


Attachments
Refactor to replace all JS function invocations in InspectorController with ScriptFunctionCall, v1 (16.56 KB, patch)
2009-04-02 14:29 PDT, Dimitri Glazkov (Google)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-04-02 14:08:10 PDT
This is fairly straightforward refactoring.
Comment 1 Dimitri Glazkov (Google) 2009-04-02 14:29:38 PDT
Created attachment 29207 [details]
Refactor to replace all JS function invocations in InspectorController with ScriptFunctionCall, v1

 WebCore/ChangeLog                              |   31 ++++++
 WebCore/bindings/js/ScriptFunctionCall.cpp     |   24 ++++
 WebCore/bindings/js/ScriptFunctionCall.h       |    9 ++
 WebCore/bindings/js/ScriptObjectQuarantine.cpp |   27 +++++
 WebCore/bindings/js/ScriptObjectQuarantine.h   |    4 +
 WebCore/inspector/InspectorController.cpp      |  135 +++++++----------------
 WebCore/inspector/InspectorController.h        |    3 -
 7 files changed, 136 insertions(+), 97 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-04-02 14:49:10 PDT
Landed as http://trac.webkit.org/changeset/42187.