Bug 25005 - Upstream V8WorkerContextObjectEventListener for V8 bindings.
Summary: Upstream V8WorkerContextObjectEventListener for V8 bindings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-02 10:49 PDT by Jian Li
Modified: 2009-04-02 14:35 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (5.92 KB, patch)
2009-04-02 10:56 PDT, Jian Li 		fishd: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-04-02 10:49:12 PDT 
Upstream V8WorkerContextObjectEventListener for V8 bindings.
Comment 1 Jian Li 2009-04-02 10:56:43 PDT 
Created attachment 29200 [details]
Proposed Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-04-02 13:10:46 PDT 
Comment on attachment 29200 [details]
Proposed Patch

> +++ b/WebCore/bindings/v8/V8WorkerContextObjectEventListener.cpp
> +#if ENABLE(WORKERS)
> +
> +#include "V8WorkerContextObjectEventListener.h"
> +
> +#include "WorkerContextExecutionProxy.h"

nit: gratuitous new line between those two includes?


otherwise, R+
Comment 3 Jian Li 2009-04-02 13:34:28 PDT 
(In reply to comment #2)
> (From update of attachment 29200 [details] [review])
> > +++ b/WebCore/bindings/v8/V8WorkerContextObjectEventListener.cpp
> > +#if ENABLE(WORKERS)
> > +
> > +#include "V8WorkerContextObjectEventListener.h"
> > +
> > +#include "WorkerContextExecutionProxy.h"
> 
> nit: gratuitous new line between those two includes?
> 
> 
> otherwise, R+
> 

Do we need additional new line between header file for itself and all other included files? It seems that other WebKit files are doing like this.
Comment 4 Dmitry Titov 2009-04-02 14:35:23 PDT 
Landed: http://trac.webkit.org/changeset/42185