Bug 25004 - Upstream V8EventListenerList for V8 bindings.
Summary: Upstream V8EventListenerList for V8 bindings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks: 25009
  Show dependency tree / graph
 
Reported: 2009-04-02 10:30 PDT by Jian Li
Modified: 2009-04-02 14:34 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (8.17 KB, patch)
2009-04-02 10:34 PDT, Jian Li 		fishd: review+
Details | Formatted Diff | Diff
Proposed Patch (8.16 KB, patch)
2009-04-02 13:23 PDT, Jian Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-04-02 10:30:49 PDT 
Upstream V8EventListenerList for V8 bindings.
Comment 1 Jian Li 2009-04-02 10:34:30 PDT 
Created attachment 29195 [details]
Proposed Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-04-02 13:08:04 PDT 
Comment on attachment 29195 [details]
Proposed Patch

> +++ b/WebCore/bindings/v8/V8EventListenerList.h
...
> +    class V8EventListenerList {
> +    public:
> +        static const size_t kMaxKeyNameLength = 254;

nit: This should be renamed to maxKeyNameLength.  Const variables should
be named just like regular variables :)

Otherwise, R+
Comment 3 Jian Li 2009-04-02 13:23:33 PDT 
Created attachment 29205 [details]
Proposed Patch

Fixed per darin's feedback. Please use this new patch to land.
Comment 4 Dmitry Titov 2009-04-02 14:34:51 PDT 
Landed: http://trac.webkit.org/changeset/42184