Bug 24997 - Race conditions in icon database threading code
Summary: Race conditions in icon database threading code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-01 20:53 PDT by Steve Falkenburg
Modified: 2009-04-01 21:52 PDT (History)
0 users

See Also:


Attachments
Set m_syncThreadRunning (1.21 KB, patch)
2009-04-01 20:55 PDT, Steve Falkenburg
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2009-04-01 20:53:32 PDT
A bug was introduced in r27717 that broke the "icon database thread is running" check.  This check is currently always returning false.

This means we don't wait until the thread has shut down during icon database closes, and also allows the icon database to be disposed out from under the icon database thread.
Comment 1 Steve Falkenburg 2009-04-01 20:55:58 PDT
Created attachment 29182 [details]
Set m_syncThreadRunning
Comment 2 Oliver Hunt 2009-04-01 21:23:11 PDT
Comment on attachment 29182 [details]
Set m_syncThreadRunning

r=me
Comment 3 Oliver Hunt 2009-04-01 21:23:12 PDT
Comment on attachment 29182 [details]
Set m_syncThreadRunning

r=me
Comment 4 Steve Falkenburg 2009-04-01 21:52:33 PDT
Fixed in r42163.