Bug 249930 – Don't add empty rects during addFocusRingRects in RenderInline

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across another failing test case in Safari 16.2 & STP160:

Test Case - https://jsfiddle.net/1gvyf5er/1/show

^ Chrome Canary 111 does not show extra focus outline to small rectangle and similar is case with Firefox Nightly 110.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/2cf30f0fb85c90f6ae813264aa0d0dcc9a85ab58

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderInline.cpp#912

Just wanted to raise since I was not able to find current bug for this.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/103897005>

[Ahmad Saleem]

Created attachment 466314 [details]
GitHub Patch

I manage to do merge and compile this but I think Line 930 is problematic since it does not fix the failing test case, which I have attached here on local build.

Just wanted to share what works so if anyone can highlight mistake, I can fix it or if they can fix it, they can take it up.

[alan baradlay]

Seems like a good merge.

[alan baradlay]

(In reply to zalan from comment #3)
> Seems like a good merge.
oops wrong bugzilla. please ignore.

[alan baradlay]

(In reply to Ahmad Saleem from comment #2)
> Created attachment 466314 [details]
> GitHub Patch
> 
> I manage to do merge and compile this but I think Line 930 is problematic
> since it does not fix the failing test case, which I have attached here on
> local build.
> 
> Just wanted to share what works so if anyone can highlight mistake, I can
> fix it or if they can fix it, they can take it up.
WebKit has addRect() and not operator(). just replace it and it will start working.

[Ahmad Saleem]

(In reply to zalan from comment #5)
> (In reply to Ahmad Saleem from comment #2)
> > Created attachment 466314 [details]
> > GitHub Patch
> > 
> > I manage to do merge and compile this but I think Line 930 is problematic
> > since it does not fix the failing test case, which I have attached here on
> > local build.
> > 
> > Just wanted to share what works so if anyone can highlight mistake, I can
> > fix it or if they can fix it, they can take it up.
> WebKit has addRect() and not operator(). just replace it and it will start
> working.

Worked!!! (Test case also fixed - test in Minibrowser). Going to draft PR first and once I will fix all bugs, I will do ask for review. :-)

[Ahmad Saleem]

(In Draft) PR - https://github.com/WebKit/WebKit/pull/13853

[EWS]

Committed 264058@main (9db465cd1226): <https://commits.webkit.org/264058@main>

Reviewed commits have been landed. Closing PR #13853 and removing active labels.