Bug 24993 - Standalone media should use a smaller intrinsic height
Summary: Standalone media should use a smaller intrinsic height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-04-01 14:33 PDT by Dean Jackson
Modified: 2009-04-01 17:58 PDT (History)
3 users (show)

See Also:


Attachments
patch for standalone audio fix (1.70 KB, patch)
2009-04-01 14:37 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2009-04-01 14:33:53 PDT
Standalone media documents use a <video> element to play all media. In the case of audio, this should not use the default intrinsic height of 150. This came up as a bug report from someone who was opening audio files in popup windows that were 100px high, and thus the controls were not visible.

By setting the intrinsic height for all media on standalone documents to 0 (actually 1, see patch comments) everything works ok. Video gets resized to its native dimensions when the video loads.

<rdar://problem/6458142> REGRESSION: Audio files have misplaced control bars (20687)
Comment 1 Dean Jackson 2009-04-01 14:37:35 PDT
Created attachment 29179 [details]
patch for standalone audio fix
Comment 2 Dean Jackson 2009-04-01 17:58:37 PDT
Committed r42159
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderVideo.cpp