WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24989
Refactor InspectorResource to use ScriptObject/FunctionCall
https://bugs.webkit.org/show_bug.cgi?id=24989
Summary
Refactor InspectorResource to use ScriptObject/FunctionCall
Dimitri Glazkov (Google)
Reported
2009-04-01 11:26:40 PDT
Following up on
bug 24524
, do the same for InspectorResource. This change is somewhat more involved. In addition to straight refactoring of JS calls, I made tracking resource changes data-driven (bit vector), rather than logic-driven, and moved it into the InspectorResource itself. The advantage is that now InspectorController can now just call InspectorResource::updateScriptResource and it will figure out which bits have been changed.
Attachments
refactor InspectorResource to use ScriptObject/FunctionCall, v1.
(57.45 KB, patch)
2009-04-01 12:18 PDT
,
Dimitri Glazkov (Google)
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-04-01 12:18:36 PDT
Created
attachment 29172
[details]
refactor InspectorResource to use ScriptObject/FunctionCall, v1. WebCore/ChangeLog | 76 ++++ .../bindings/js/JSInspectorControllerCustom.cpp | 14 +- WebCore/bindings/js/ScriptFunctionCall.cpp | 6 + WebCore/bindings/js/ScriptFunctionCall.h | 1 + WebCore/bindings/js/ScriptObject.cpp | 71 ++++ WebCore/bindings/js/ScriptObject.h | 10 + WebCore/inspector/InspectorController.cpp | 434 +++----------------- WebCore/inspector/InspectorController.h | 16 +- WebCore/inspector/InspectorController.idl | 4 +- WebCore/inspector/InspectorResource.cpp | 315 +++++++++++--- WebCore/inspector/InspectorResource.h | 121 ++++-- 11 files changed, 571 insertions(+), 497 deletions(-)
Dimitri Glazkov (Google)
Comment 2
2009-04-01 15:49:51 PDT
Landed as
http://trac.webkit.org/changeset/42155
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug