RESOLVED INVALID 249760
Match epsilon value to output digits in TextStream.cpp 
https://bugs.webkit.org/show_bug.cgi?id=249760
Summary Match epsilon value to output digits in TextStream.cpp
Ahmad Saleem
Reported 2022-12-21 18:44:20 PST
Hi Team, I noticed that Blink team added this commit to reduce flakiness in the test cases (especially SVG), I just wanted to get opinion whether it is something worth adding or changing in WebKit: Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=186819 Webkit GitHub Source - https://src.chromium.org/viewvc/blink?view=revision&revision=186819 Commit message crux: "This patch brings epsilon to 0.01 so we shouldn't change whether or not we display a fraction without a numerical difference in our output." Just wanted to get opinion. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-12-21 19:50:34 PST
Looks like we have this code in Source/WTF/wtf/text/TextStream.cpp, but I don't really know what it's meant to do. I don't think that we have any flakiness in render tree dumps, although we do have platform specific results that differ only a little.
alan
Comment 2 2022-12-21 21:16:50 PST
I am not aware of any flakiness either.
Radar WebKit Bug Importer
Comment 3 2022-12-28 18:45:16 PST
<rdar://problem/103750146>
Ahmad Saleem
Comment 4 2023-10-18 15:25:07 PDT
Nothing much to do here.
Note You need to log in before you can comment on or make changes to this bug.