Bug 249663 - [ews-build.webkit.org] Use TwistedAdditions in place of Twisted requests
Summary: [ews-build.webkit.org] Use TwistedAdditions in place of Twisted requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 250771
  Show dependency tree / graph
 
Reported: 2022-12-20 11:36 PST by Jonathan Bedard
Modified: 2023-01-18 10:30 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-12-20 11:36:51 PST 
When making a request to ews.webkit.org or GitHub.com, we should use TwistedAdditions instead of making a Twisted request so we can share the code needed to build a Twisted request in TwistedAdditions.
Comment 1 Radar WebKit Bug Importer 2022-12-20 11:37:04 PST 
<rdar://problem/103564994>
Comment 2 Jonathan Bedard 2022-12-20 11:48:07 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7922
Comment 3 EWS 2023-01-06 07:28:37 PST 
Committed 258542@main (fa3e08712e32): <https://commits.webkit.org/258542@main>

Reviewed commits have been landed. Closing PR #7922 and removing active labels.
Comment 4 Jonathan Bedard 2023-01-06 08:01:03 PST 
Reverted by https://github.com/WebKit/WebKit/pull/8302
Comment 5 Jonathan Bedard 2023-01-06 08:01:07 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/8302
Comment 6 EWS 2023-01-06 08:07:17 PST 
Committed 258543@main (226b2f3cb9fa): <https://commits.webkit.org/258543@main>

Reviewed commits have been landed. Closing PR #8302 and removing active labels.
Comment 7 Jonathan Bedard 2023-01-06 10:38:23 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/8312
Comment 8 EWS 2023-01-07 08:03:14 PST 
Committed 258615@main (efaf35700c5f): <https://commits.webkit.org/258615@main>

Reviewed commits have been landed. Closing PR #8312 and removing active labels.