WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
249663
[ews-build.webkit.org] Use TwistedAdditions in place of Twisted requests
https://bugs.webkit.org/show_bug.cgi?id=249663
Summary
[ews-build.webkit.org] Use TwistedAdditions in place of Twisted requests
Jonathan Bedard
Reported
2022-12-20 11:36:51 PST
When making a request to ews.webkit.org or GitHub.com, we should use TwistedAdditions instead of making a Twisted request so we can share the code needed to build a Twisted request in TwistedAdditions.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-20 11:37:04 PST
<
rdar://problem/103564994
>
Jonathan Bedard
Comment 2
2022-12-20 11:48:07 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7922
EWS
Comment 3
2023-01-06 07:28:37 PST
Committed
258542@main
(fa3e08712e32): <
https://commits.webkit.org/258542@main
> Reviewed commits have been landed. Closing PR #7922 and removing active labels.
Jonathan Bedard
Comment 4
2023-01-06 08:01:03 PST
Reverted by
https://github.com/WebKit/WebKit/pull/8302
Jonathan Bedard
Comment 5
2023-01-06 08:01:07 PST
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/8302
EWS
Comment 6
2023-01-06 08:07:17 PST
Committed
258543@main
(226b2f3cb9fa): <
https://commits.webkit.org/258543@main
> Reviewed commits have been landed. Closing PR #8302 and removing active labels.
Jonathan Bedard
Comment 7
2023-01-06 10:38:23 PST
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/8312
EWS
Comment 8
2023-01-07 08:03:14 PST
Committed
258615@main
(efaf35700c5f): <
https://commits.webkit.org/258615@main
> Reviewed commits have been landed. Closing PR #8312 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug