Bug 249630 - OffscreenCanvas should use the same buffer size checks as HTMLCanvasElement
Summary: OffscreenCanvas should use the same buffer size checks as HTMLCanvasElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-19 19:36 PST by Matt Woodrow
Modified: 2022-12-22 01:00 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-12-19 19:36:39 PST 
<rdar://103177223>

HTMLCanvasElement has a lot of checks to determine if the specified size is within an acceptable range, whereas OffscreenCanvas will just allocate giant buffers if requested.

We should share the logic in CanvasBase so that we have consistent behaviour.
Comment 1 Matt Woodrow 2022-12-19 19:39:24 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7895
Comment 2 EWS 2022-12-22 01:00:31 PST 
Committed 258237@main (d21c61e18c6f): <https://commits.webkit.org/258237@main>

Reviewed commits have been landed. Closing PR #7895 and removing active labels.