Bug 249627 – option and optgroup shouldn't be focusable if they are hidden or in a menulist

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across few more test cases failure:

Test Case - https://jsfiddle.net/n80ompfr/show

^ Safari 16.2 and STP160 both fail a single test case while Chrome Canary 111 and Firefox Nightly 110 passes all.

Test Case - 2 - https://jsfiddle.net/grwehdk6/show

^ Safari 16.2 and STP160 both fail two test cases while Chrome Canary 111 and Firefox Nightly 110 passes all.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/db4eb7807f1591c3beebe2e40a3c57d9e57a3c85

Just wanted to raise this bug so we can track this. Might try to do PR later.

Thanks!

[Ryosuke Niwa]

Seems sensible to merge this.

[Radar WebKit Bug Importer]

<rdar://problem/103717395>

[Ahmad Saleem]

Just need to add:

RefPtr select = ownerSelectElement();
    if (select && select->usesMenuList())
        return false;
    return HTMLElement::isFocusable();

in HTMLOptionElement::isFocusable() and HTMLOptGroupElement::isFocusable(), no need to introduce new functions like Blink patch.

Just fixed it locally, will do PR shortly.

[Ahmad Saleem]

Fingers Crossed - https://github.com/WebKit/WebKit/pull/14507

[EWS]

Committed 264755@main (b9e0d14b62e6): <https://commits.webkit.org/264755@main>

Reviewed commits have been landed. Closing PR #14507 and removing active labels.