Bug 249612 - Fix issue where WebAuth timeouts lead to an incorrect error
Summary: Fix issue where WebAuth timeouts lead to an incorrect error
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Wolfe
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-19 15:28 PST by Charlie Wolfe
Modified: 2022-12-20 11:20 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Wolfe 2022-12-19 15:28:42 PST
When an auth prompt times out it leads to an HierarchyRequestError, which is incorrect.
Comment 1 Charlie Wolfe 2022-12-19 15:29:10 PST
rdar://100825830
Comment 2 Charlie Wolfe 2022-12-19 15:36:06 PST
Pull request: https://github.com/WebKit/WebKit/pull/7879
Comment 3 EWS 2022-12-19 18:31:18 PST
Committed 258116@main (56aa37f2fb91): <https://commits.webkit.org/258116@main>

Reviewed commits have been landed. Closing PR #7879 and removing active labels.
Comment 4 Robert Jenner 2022-12-20 11:20:29 PST
It appears that this commit broke the following two API tests for iOS:

TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform
TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout

I have confirmed that the regression point was 258116@main because the tests fail at that commit, but pass at the commit directly before it.