WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
249607
Div having contentEditable and display:grid cannot be edited if it is empty
https://bugs.webkit.org/show_bug.cgi?id=249607
Summary
Div having contentEditable and display:grid cannot be edited if it is empty
Ahmad Saleem
Reported
2022-12-19 13:45:13 PST
Hi Team, While going through Blink's commit, I came across another failing test case: Test Case -
https://jsfiddle.net/0apf247s/
^Fail in Safari 16.2 & STP160, it only passes in Chrome Canary 111 while Firefox Nightly 110 also fail two sub-tests. Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/514f6e13a5a64aa675d3dc42a2707161d71737c2
I haven't looked into whether it can be merged 1-1 but I just wanted to raise this so we can track this bug. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-26 13:46:16 PST
<
rdar://problem/103713842
>
Ahmad Saleem
Comment 2
2023-08-03 17:21:30 PDT
Don't need to this change:
https://searchfox.org/wubkat/source/Source/WebCore/dom/Position.cpp#1006
Already have:
>> is<RenderBlockFlow>(*renderer) || is<RenderGrid>(*renderer) || is<RenderFlexibleBox>(*renderer)
and this needs to be updated:
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFlexibleBox.cpp#1366
Still looking for other bits in RenderGrid.cpp.
Ahmad Saleem
Comment 3
2023-08-03 17:23:08 PDT
I think 'RenderGrid' related changes would be here:
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderGrid.cpp#363
Ahmad Saleem
Comment 4
2024-12-25 14:59:19 PST
This is already done -
https://commits.webkit.org/159585@main
We might be failing subtest due to innerText difference. Closing this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug