WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
249495
Introduce CallFrame::returnPCForInspection(), and removed some unused code.
https://bugs.webkit.org/show_bug.cgi?id=249495
Summary
Introduce CallFrame::returnPCForInspection(), and removed some unused code.
Mark Lam
Reported
2022-12-16 12:49:43 PST
CallFrame::returnPC() was relying on ReturnAddressPtr, which in turn expected to be able to untag any arbitrary return address read from a stack frame. This will not always be possible when JITCage is enabled. Also, CallFrame::returnPC() is only used for debugging purposes. So, this patch will simplify its implementation and rename it to CallFrame::returnPCForInspection() to make it clear that it should only be used for debugging and analysis purposes. We will also remove some related unused code.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-16 12:50:07 PST
<
rdar://problem/103457282
>
Mark Lam
Comment 2
2022-12-16 13:10:17 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7775
EWS
Comment 3
2022-12-16 15:58:52 PST
Committed
258023@main
(689b0ba375c8): <
https://commits.webkit.org/258023@main
> Reviewed commits have been landed. Closing PR #7775 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug