Bug 249460 – web platform tests that build up keydown and keyup events using test_driver.Actions fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

WPT tests that use test_driver.Actions.keyDown/keyUp straight up fail.

[Ryosuke Niwa]

Created attachment 464071 [details]
WIP

[Ryosuke Niwa]

Created attachment 464072 [details]
WIP2

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Tim Nguyen (:ntim)]

Comment on attachment 464072 [details]
WIP2

View in context: https://bugs.webkit.org/attachment.cgi?id=464072&action=review

> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:287
> +    if (keySource && pointerSource)
> +        throw new Error("testdriver-vendor.js for WebKit does not yet support mixing key and pointer sources");

Here's how the logic could be refactored to support both at once: https://bugs.webkit.org/attachment.cgi?id=461570&action=review

(This is a WIP for wheel actions in WKTR, very similar to what you're doing here)

[Ryosuke Niwa]

Created attachment 464112 [details]
WIP3

[Radar WebKit Bug Importer]

<rdar://problem/103664916>

[Ryosuke Niwa]

Pull request: https://github.com/WebKit/WebKit/pull/9426

[EWS]

Committed 259822@main (790c299b40fb): <https://commits.webkit.org/259822@main>

Reviewed commits have been landed. Closing PR #9426 and removing active labels.