Bug 249458 - [GTK] [2.39.3] Non-unified builds broken
Summary: [GTK] [2.39.3] Non-unified builds broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-16 01:07 PST by Alberto Garcia
Modified: 2022-12-16 12:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.40 KB, patch)
2022-12-16 01:07 PST, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Patch (13.97 KB, patch)
2022-12-16 03:45 PST, Alberto Garcia 		mcatanzaro: review+
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2022-12-16 01:07:33 PST 
Created attachment 464070 [details]
Patch

The patch is against main but it applies cleanly except for CSSPropertySyntax.cpp which was recently renamed.
Comment 1 Alberto Garcia 2022-12-16 03:45:26 PST 
Created attachment 464075 [details]
Patch

Sorry, the previous patch had style errors, here's the updated one
Comment 2 Michael Catanzaro 2022-12-16 06:37:48 PST 
Comment on attachment 464075 [details]
Patch

Hi Berto, can you please add the COMMIT_MESSAGE following the usual template? Then we won't have to modify the patch for you.
Comment 3 Alberto Garcia 2022-12-16 10:46:37 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7761
Comment 4 Alberto Garcia 2022-12-16 10:47:05 PST 
I had to update the patch after the latest changes in main, now with a pull request
Comment 5 EWS 2022-12-16 12:30:45 PST 
Committed 258011@main (cc4248a1c61e): <https://commits.webkit.org/258011@main>

Reviewed commits have been landed. Closing PR #7761 and removing active labels.