Bug 249415 - PR branch names should use the issue number as the canonical reference, not the title string
Summary: PR branch names should use the issue number as the canonical reference, not t...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-12-15 11:05 PST by Simon Fraser (smfr)
Modified: 2022-12-22 11:06 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-12-15 11:05:39 PST 
`git webkit pr --issue 249413` when you're already on the PR branch for issue 249413 should not throw an error like it does today:

OpenSource % git webkit pr --issue 249413
Creating a pull-request for '249413' but we're on 'eng/webkitparser-py-should-give-a-better-error-message-when-message-arguments-are-unnamed'

We should fix this by putting the issue number at the start of the branch name, so that the scripts can always associate a branch with an issue. This also makes the branch name immune to retitling the issue.

I suggest:
eng/249413-Foo-bar-baz for bugzilla issues
eng/rdar10249413-Foo-bar-baz for radar issues
Comment 1 Simon Fraser (smfr) 2022-12-15 11:06:46 PST 
It's also perfectly reasonable to have multiple issues with the same name ("Gardening iOS tests"), which is also not possible with the current branch naming strategy
Comment 2 Radar WebKit Bug Importer 2022-12-22 11:06:16 PST 
<rdar://problem/103643814>