Bug 24938 - --no-svg has build problems
Summary: --no-svg has build problems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-30 10:15 PDT by Greg Bolsinga
Modified: 2009-03-30 13:00 PDT (History)
2 users (show)

See Also:


Attachments
This patch addresses the build problems (7.71 KB, patch)
2009-03-30 10:16 PDT, Greg Bolsinga
simon.fraser: review+
Details | Formatted Diff | Diff
Build fixes for building --3d-rendering and --no-svg (976 bytes, patch)
2009-03-30 11:26 PDT, Greg Bolsinga
simon.fraser: review+
Details | Formatted Diff | Diff
sorted switch statement (1.56 KB, patch)
2009-03-30 12:42 PDT, Greg Bolsinga
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2009-03-30 10:15:44 PDT
When building with:

./WebKitTools/Scripts/build-webkit --no-svg --no-svg-animation --no-svg-filters --no-svg-foreign-object --no-svg-fonts --no-svg-as-image --no-svg-use

there are build errors. This fixes the compilation problems.

The WebCore.xcode project is copying DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h. These are only generated when building ENABLE_SVG. I am not sure of the best way to conditionally copy those header files.
Comment 1 Greg Bolsinga 2009-03-30 10:16:11 PDT
Created attachment 29075 [details]
This patch addresses the build problems
Comment 2 Simon Fraser (smfr) 2009-03-30 10:29:03 PDT
Comment on attachment 29075 [details]
This patch addresses the build problems

=>          case CSSPropertyWebkitTextStroke:
>          case CSSPropertyWebkitTransition:
>          case CSSPropertyWebkitVariableDeclarationBlock:
> +        case CSSPropertyWebkitPerspectiveOriginX:
> +        case CSSPropertyWebkitPerspectiveOriginY:
> +        case CSSPropertyWebkitTransformOriginX:
> +        case CSSPropertyWebkitTransformOriginY:
> +        case CSSPropertyWebkitTransformOriginZ:

I think these were left out on purpose. We don't want authors to get style for 'transform-origin-x' etc, just the compound property 'transform-origin'.

> Index: WebCore/css/CSSParser.cpp
> ===================================================================
> --- WebCore/css/CSSParser.cpp	(revision 42106)
> +++ WebCore/css/CSSParser.cpp	(working copy)
> @@ -1625,6 +1625,7 @@ bool CSSParser::parseValue(int propId, b
>      case CSSPropertyTextLineThrough:
>      case CSSPropertyTextOverline:
>      case CSSPropertyTextUnderline:
> +    case CSSPropertyWebkitVariableDeclarationBlock:
>          return false;

I don't see enough context to know if this is correct. I belive CSS variables are disabled now anyway.

> Index: WebCore/css/CSSStyleSelector.cpp
> ===================================================================
> --- WebCore/css/CSSStyleSelector.cpp	(revision 42106)
> +++ WebCore/css/CSSStyleSelector.cpp	(working copy)
> @@ -5185,6 +5185,7 @@ void CSSStyleSelector::applyProperty(int
>      case CSSPropertyWebkitPaddingStart:
>      case CSSPropertyWebkitTextDecorationsInEffect:
>      case CSSPropertyWebkitTextStroke:
> +    case CSSPropertyWebkitVariableDeclarationBlock:

Ditto.
Comment 3 Simon Fraser (smfr) 2009-03-30 10:32:54 PDT
(In reply to comment #2)
> (From update of attachment 29075 [details] [review])
> =>          case CSSPropertyWebkitTextStroke:
> >          case CSSPropertyWebkitTransition:
> >          case CSSPropertyWebkitVariableDeclarationBlock:
> > +        case CSSPropertyWebkitPerspectiveOriginX:
> > +        case CSSPropertyWebkitPerspectiveOriginY:
> > +        case CSSPropertyWebkitTransformOriginX:
> > +        case CSSPropertyWebkitTransformOriginY:
> > +        case CSSPropertyWebkitTransformOriginZ:
> 
> I think these were left out on purpose. We don't want authors to get style for
> 'transform-origin-x' etc, just the compound property 'transform-origin'.

Never mind, these are fine. Stupid svg 'default' statement.
Comment 4 Greg Bolsinga 2009-03-30 11:04:53 PDT
bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/css/CSSComputedStyleDeclaration.cpp
Sending        WebCore/css/CSSCursorImageValue.cpp
Sending        WebCore/css/CSSParser.cpp
Sending        WebCore/css/CSSStyleSelector.cpp
Sending        WebCore/dom/Node.cpp
Sending        WebCore/platform/graphics/Font.cpp
Sending        WebCore/platform/graphics/SimpleFontData.cpp
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/MigrateHeaders.make
Transmitting file data ..........
Committed revision 42112.
Comment 5 Greg Bolsinga 2009-03-30 11:26:06 PDT
Created attachment 29079 [details]
Build fixes for building --3d-rendering and --no-svg
Comment 6 Greg Bolsinga 2009-03-30 11:33:56 PDT
bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/rendering/RenderLayerBacking.cpp
Transmitting file data ..
Committed revision 42115.
Comment 7 Darin Adler 2009-03-30 12:07:50 PDT
Comment on attachment 29075 [details]
This patch addresses the build problems

>          case CSSPropertyWebkitTextStroke:
>          case CSSPropertyWebkitTransition:
>          case CSSPropertyWebkitVariableDeclarationBlock:
> +        case CSSPropertyWebkitPerspectiveOriginX:
> +        case CSSPropertyWebkitPerspectiveOriginY:
> +        case CSSPropertyWebkitTransformOriginX:
> +        case CSSPropertyWebkitTransformOriginY:
> +        case CSSPropertyWebkitTransformOriginZ:

Should be sorted alphabetically. Same for other switch statements in the patch that are currently sorted. Please don't add the first non-sorted items.
Comment 8 Greg Bolsinga 2009-03-30 12:42:58 PDT
Created attachment 29081 [details]
sorted switch statement

The other switch statements are sorted within their "return false" groupings.
Comment 9 Greg Bolsinga 2009-03-30 12:43:15 PDT
Re-opening for new review.
Comment 10 Greg Bolsinga 2009-03-30 13:00:13 PDT
bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/css/CSSComputedStyleDeclaration.cpp
Transmitting file data ..
Committed revision 42116.