WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
249340
[ews] Optimization to reduce number of results database lookups
https://bugs.webkit.org/show_bug.cgi?id=249340
Summary
[ews] Optimization to reduce number of results database lookups
Aakash Jain
Reported
2022-12-14 14:46:06 PST
When there are lot of test failures, we consult results db for every failure. However, we can bypass the retry logic only if ALL the test failures are pre-existing. If even one failure is not pre-existing, we can't benefit from results database lookups. So, we can optimize the number of results database calls, by skipping consulting results-db for further tests the moment we know that one of the test failure is not pre-existing. Number of test failures (and resulting number of results db calls) can be lot for some queues, e.g.: 170 on GTK-WK2-Tests-EWS queue in
https://ews-build.webkit.org/#/builders/35/builds/34489/steps/23/logs/test-failures
. Even on mac/ios queue it can be upto 60 failures (after
https://commits.webkit.org/257442@main
). So this change would help reduce unnecessary results database calls in those cases.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-14 14:47:56 PST
<
rdar://problem/103373814
>
Aakash Jain
Comment 2
2022-12-14 14:49:11 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7642
EWS
Comment 3
2022-12-14 15:27:54 PST
Committed
257881@main
(d57630c96a63): <
https://commits.webkit.org/257881@main
> Reviewed commits have been landed. Closing PR #7642 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug