Bug 249337 - `font-variant-alternates: historical-forms` doesn't reflect properly via StylePropertyMap
Summary: `font-variant-alternates: historical-forms` doesn't reflect properly via Styl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://w3c.github.io/csswg-drafts/cs...
Keywords: InRadar
Depends on:
Blocks: 175733
  Show dependency tree / graph
 
Reported: 2022-12-14 14:10 PST by Chris Dumez
Modified: 2022-12-15 13:55 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-12-14 14:10:12 PST 
`font-variant-alternates: historical-forms` doesn't reflect properly via StylePropertyMap. Even though `historical-forms` is a supported keyword for this CSS property [1], we wouldn't get a CSSKeywordValue when reading the property value back. The issue is that we convert to a FontVariantAlternates internally and then back to a CSSValue. The function to convert back to a CSSValue (fontVariantAlternatesPropertyValue) was only handling the `normal` keyword but not the `historical-forms` one.

[1] https://w3c.github.io/csswg-drafts/css-fonts/#font-variant-alternates-prop
Comment 1 Chris Dumez 2022-12-14 14:12:06 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7640
Comment 2 EWS 2022-12-15 13:54:16 PST 
Committed 257955@main (37f48652e37e): <https://commits.webkit.org/257955@main>

Reviewed commits have been landed. Closing PR #7640 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-15 13:55:19 PST 
<rdar://problem/103417243>