Bug 249330 – REGRESSION(257823@main): named-groups/lookbehind.js Test262-test is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Robert Jenner]

The following 10 Test262 tests are constant failures on Monterey:

test/built-ins/RegExp/named-groups/lookbehind.js 
test/built-ins/RegExp/named-groups/lookbehind.js 
test/language/literals/regexp/invalid-optional-lookbehind.js 
test/language/literals/regexp/invalid-optional-lookbehind.js 
test/language/literals/regexp/invalid-optional-negative-lookbehind.js 
test/language/literals/regexp/invalid-optional-negative-lookbehind.js 
test/language/literals/regexp/invalid-range-lookbehind.js 
test/language/literals/regexp/invalid-range-lookbehind.js 
test/language/literals/regexp/invalid-range-negative-lookbehind.js 
test/language/literals/regexp/invalid-range-negative-lookbehind.js 


Observed here:
https://build.webkit.org/#/builders/364/builds/10429


FAILURE TEXT:

FAIL test/built-ins/RegExp/named-groups/lookbehind.js (default)
Full Output:
Exception: Test262Error: Expected [f, undefined] and [f, c] to have the same contents. 
FAIL test/built-ins/RegExp/named-groups/lookbehind.js (strict mode)
Full Output:
Exception: Test262Error: Expected [f, undefined] and [f, c] to have the same contents. 
FAIL test/language/literals/regexp/invalid-optional-lookbehind.js (default)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-optional-lookbehind.js (strict mode)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-optional-negative-lookbehind.js (default)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-optional-negative-lookbehind.js (strict mode)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-range-lookbehind.js (default)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-range-lookbehind.js (strict mode)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-range-negative-lookbehind.js (default)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.
FAIL test/language/literals/regexp/invalid-range-negative-lookbehind.js (strict mode)
Full Output:
Expected uncaught exception with name 'SyntaxError' but exception value is not instance of this exception class
Exception: Test262: This statement should not be evaluated.

[Radar WebKit Bug Importer]

<rdar://problem/103367993>

[Robert Jenner]

Actually it turns out there are only 5 tests, they just run twice. Once in default the other in strict. The 5 tests are:

test/built-ins/RegExp/named-groups/lookbehind.js 
test/language/literals/regexp/invalid-optional-lookbehind.js 
test/language/literals/regexp/invalid-optional-negative-lookbehind.js 
test/language/literals/regexp/invalid-range-lookbehind.js 
test/language/literals/regexp/invalid-range-negative-lookbehind.js

[Robert Jenner]

Pull request: https://github.com/WebKit/WebKit/pull/7632

[EWS]

Test gardening commit 257874@main (2b71676e9148): <https://commits.webkit.org/257874@main>

Reviewed commits have been landed. Closing PR #7632 and removing active labels.

[Michael Saboff]

he failure in this test has nothing to do with named capture groups.  The issue is that we don't clear out a capture nested within a failed lookbehind.  This actually is a long standing issue as we don't clear out nested captures within a failed lookahead.  There is a long standing FIXME comment in the JIT code.

I have a fix that I'll post soon.

[Michael Saboff]

Pull request: https://github.com/WebKit/WebKit/pull/7940

[EWS]

Committed 258195@main (6204c47b8556): <https://commits.webkit.org/258195@main>

Reviewed commits have been landed. Closing PR #7940 and removing active labels.

[Fujii Hironori]

Bug 249812 – REGRESSION(258195@main) [Win] ASSERTION FAILED: subpattern in JSC::Yarr::YarrGenerator<JSC::Yarr::YarrJITDefaultRegisters>::clearSubpatternStart

[WebKit Commit Bot]

Re-opened since this is blocked by bug 249855

[Michael Saboff]

Pull request: https://github.com/WebKit/WebKit/pull/8170

[EWS]

Committed 258441@main (cbde560aa655): <https://commits.webkit.org/258441@main>

Reviewed commits have been landed. Closing PR #8170 and removing active labels.