Bug 249303 – [ New Test ] (257736@main): [ macOS Debug ] ASSERTION FAILED: m_targetWindowForMovePreparation => m_targetWindowForMovePreparation == window

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Karl Rackler]

Description:
TestWebKitAPI.WKWebView.PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers is a consistent crash

The test was added at 257736@main and has been a consistent crash since then.

This issue can be bisected to 257736@main using the command: 
run-api-tests --debug TestWebKitAPI.WKWebView.PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers

History:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebView.PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers&style=debug&limit=50000

Crashed

    TestWebKitAPI.WKWebView.PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers
        ASSERTION FAILED: m_targetWindowForMovePreparation => m_targetWindowForMovePreparation == window
        /Volumes/Data/worker/trunk-sunburst-debug-archive/build/OpenSource/Source/WebKit/UIProcess/mac/WebViewImpl.mm(2120) : void WebKit::WebViewImpl::viewWillMoveToWindowImpl(NSWindow *)
        1   0x124227fa9 WTFCrash
        2   0x152eb3435 WebKit::WebViewImpl::viewWillMoveToWindowImpl(NSWindow*)
        3   0x152eb4d8f WebKit::WebViewImpl::prepareForMoveToWindow(NSWindow*, WTF::Function<void ()>&&)
        4   0x152b88b70 -[WKWebView(WKPrivateMac) _prepareForMoveToWindow:completionHandler:]
        5   0x10fea297c WKWebView_PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers_Test::TestBody()
        6   0x1105718db void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        7   0x11053c69a void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        8   0x11053c5e3 testing::Test::Run()
        9   0x11053d761 testing::TestInfo::Run()
        10  0x11053e7a4 testing::TestSuite::Run()
        11  0x11054d76b testing::internal::UnitTestImpl::RunAllTests()
        12  0x11057629b bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        13  0x11054d12a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        14  0x11054d015 testing::UnitTest::Run()
        15  0x10fb75071 RUN_ALL_TESTS()
        16  0x10fb75006 TestWebKitAPI::TestsController::run(int, char**)
        17  0x11050c832 main
        18  0x7ff819a5942c start
        LEAK: 1 WebPage
        LEAK: 1 WebFrame
        LEAK: 4 RenderObject
        LEAK: 1 Page
        LEAK: 1 Frame
        LEAK: 1 CachedResource
        LEAK: 5 WebCoreNode

[Radar WebKit Bug Importer]

<rdar://problem/103352822>

[Karl Rackler]

Revert: https://commits.webkit.org/257848@main

[Alexey Proskuryakov]

Moving to FIXED, as this was addressed by a revert.