Bug 249295 – Add size assert for Element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Rob Buis]

Add size assert for Element based on the FIXME in Element.h

[Rob Buis]

Created attachment 464036 [details]
Patch

[Rob Buis]

Pull request: https://github.com/WebKit/WebKit/pull/7604

[Radar WebKit Bug Importer]

<rdar://problem/103591863>

[EWS]

Committed 258238@main (80db98e4cb00): <https://commits.webkit.org/258238@main>

Reviewed commits have been landed. Closing PR #7604 and removing active labels.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 249874

[Rob Buis]

Pull request: https://github.com/WebKit/WebKit/pull/8102

[EWS]

Committed 258366@main (763cf9e589db): <https://commits.webkit.org/258366@main>

Reviewed commits have been landed. Closing PR #8102 and removing active labels.

[Simon Fraser (smfr)]

Comment on attachment 464036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464036&action=review

> Source/WebCore/dom/Element.cpp:151
> +struct SameSizeAsElement : public ContainerNode {

This doesn't detect when ContainerNode grows (and it has no size check).

[Rob Buis]

Comment on attachment 464036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464036&action=review

>> Source/WebCore/dom/Element.cpp:151
>> +struct SameSizeAsElement : public ContainerNode {
> 
> This doesn't detect when ContainerNode grows (and it has no size check).

I have a follow up patch for asserting Element base class sizes, as suggested by Sam on slack, will put it up tomorrow.

[Yusuke Suzuki]

Note that we are not seeing Speedometer2 regression with the relanded revised change (using EventTargetFlag).