RESOLVED WORKSFORME 249267
Optimize Element::attributeChanged() 
https://bugs.webkit.org/show_bug.cgi?id=249267
Summary Optimize Element::attributeChanged()
Ahmad Saleem
Reported 2022-12-13 15:37:10 PST
Hi Team, We are fastest in the benchmarks mentioned in the following Blink Commit, but I am raising this to see if this can be salvaged or if similar can be applied to further improve the performance or this is something already achieved and don't serve any benefit. This is just to get input. Performance Benchmark: https://jsfiddle.net/hr7Lm5jq/ & https://jsfiddle.net/x3kv4gut/ Blink Commit - https://chromium.googlesource.com/chromium/blink/+/3ac59c7df4f1f92a3ec0fa712a14810d62b02204 Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/bfd520b659e89b66f32b4863609a704e8c81357f/Source/WebCore/dom/Element.cpp#L2000 Just wanted to raise this for input. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-12-20 15:38:17 PST
<rdar://problem/103574052>
Darin Adler
Comment 2 2023-01-30 15:16:44 PST
This optimization is about code that is totally different in Blink. We don’t have this isPresentationAttribute concept. Not sure we have something analogous.
Ahmad Saleem
Comment 3 2023-09-09 15:31:53 PDT
Safari Technology Preview 178 is faster than Chrome Canary 118 and Firefox Nightly 118 in both performance benchmarks. Closing it as 'RESOLVED WORKSFORME'.
Note You need to log in before you can comment on or make changes to this bug.