Bug 24922 - change WorkQueue-based navigation tests to not depend on synchronous form submission
Summary: change WorkQueue-based navigation tests to not depend on synchronous form sub...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 22378
  Show dependency tree / graph
 
Reported: 2009-03-29 08:52 PDT by Darin Adler
Modified: 2009-03-29 12:27 PDT (History)
1 user (show)

See Also:

Attachments
patch (39.43 KB, patch)
2009-03-29 09:38 PDT, Darin Adler 		zwarich: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2009-03-29 08:52:34 PDT 
Some of the regression tests depend on our current synchronous form submission, which is not the same as other browsers.
Comment 1 Darin Adler 2009-03-29 09:38:51 PDT 
Created attachment 29046 [details]
patch
Comment 2 Cameron Zwarich (cpst) 2009-03-29 10:04:04 PDT 
Comment on attachment 29046 [details]
patch

> // Not dumping as text since the DumpRenderTree does not dump the text conetnt of child frames.

There is a typo here: "conetnt" should be "content". After runTest() there should probably be a blank line before subframeLoaded(), but I am not sure how strict we are on style in test files.

Other than that, r=me.
Comment 3 Darin Adler 2009-03-29 12:27:41 PDT 
http://trac.webkit.org/changeset/42082